Unit testing extension method adding view location expander Planned maintenance scheduled April 23, 2019 at 23:30UTC (7:30pm US/Eastern) Announcing the arrival of Valued Associate #679: Cesar Manara Unicorn Meta Zoo #1: Why another podcast?Unit testing extension for equality testingCalculate the physical centreAre these the right type of unit tests to write?File validation and unit testingUnit Testing in VBAUnit testing a service to return items from a databaseValidation extensions v2Java REST-assured acceptance testsGenerate pieces of an SQL queryUnit testing a generic interface: proposal to avoid test duplication for different generic types
Sliceness of knots
How often does castling occur in grandmaster games?
One-one communication
What does 丫 mean? 丫是什么意思?
Is CEO the "profession" with the most psychopaths?
Why are vacuum tubes still used in amateur radios?
What would you call this weird metallic apparatus that allows you to lift people?
What is an "asse" in Elizabethan English?
Crossing US/Canada Border for less than 24 hours
Why weren't discrete x86 CPUs ever used in game hardware?
How to report t statistic from R
In musical terms, what properties are varied by the human voice to produce different words / syllables?
The Nth Gryphon Number
Why does it sometimes sound good to play a grace note as a lead in to a note in a melody?
Is it fair for a professor to grade us on the possession of past papers?
Where is the Data Import Wizard Error Log
What is the meaning of 'breadth' in breadth first search?
Co-worker has annoying ringtone
How can I prevent/balance waiting and turtling as a response to cooldown mechanics
Should a wizard buy fine inks every time he want to copy spells into his spellbook?
Most bit efficient text communication method?
What is Adi Shankara referring to when he says "He has Vajra marks on his feet"?
How do I find out the mythology and history of my Fortress?
What does it mean that physics no longer uses mechanical models to describe phenomena?
Unit testing extension method adding view location expander
Planned maintenance scheduled April 23, 2019 at 23:30UTC (7:30pm US/Eastern)
Announcing the arrival of Valued Associate #679: Cesar Manara
Unicorn Meta Zoo #1: Why another podcast?Unit testing extension for equality testingCalculate the physical centreAre these the right type of unit tests to write?File validation and unit testingUnit Testing in VBAUnit testing a service to return items from a databaseValidation extensions v2Java REST-assured acceptance testsGenerate pieces of an SQL queryUnit testing a generic interface: proposal to avoid test duplication for different generic types
.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty margin-bottom:0;
$begingroup$
Introduction
I'm writing unit tests for an extension method I wrote. Its only purpose it is to wrap startup logic which extends ViewLocationExpanders
list by an instance implementating IViewLocationExpander
. ViewLocationExpanders
is a property of RazorViewEngineOptions
, which can be configured in application startup in ConfigureServices()
method. I'm using XUnit 2.4.1.
Usage
Instead of:
services.Configure<RazorViewEngineOptions>(options =>
options.ViewLocationExpanders.Add(new ViewLocationExpander());
);
I can use:
services.AddViewLocationExpander(new ViewLocationExpander());
ViewLocationExpander
public class ViewLocationExpander : IViewLocationExpander
public IEnumerable<string> ExpandViewLocations(
ViewLocationExpanderContext context,
IEnumerable<string> viewLocations)
if (context == null)
throw new ArgumentNullException(nameof(context));
if (viewLocations == null)
throw new ArgumentNullException(nameof(viewLocations));
/*
* Note:
* 0 = action name
* 1 = controller name
* 2 = area name
*/
var newViewLocations = new string[]
// Example: '/Views/Home/_Partials/FooBar.cshtml'
"/Views/1/_Partials/0.cshtml",
;
// Add new locations *AFTER* MVC default locations.
return viewLocations.Union(newViewLocations);
public void PopulateValues(ViewLocationExpanderContext context)
context.Values["customviewlocation"] = nameof(ViewLocationExpander);
Extension method
public static IServiceCollection AddViewLocationExpander(
this IServiceCollection services,
IViewLocationExpander viewLocationExpander)
if (services == null)
throw new ArgumentNullException(nameof(services));
if (viewLocationExpander == null)
throw new ArgumentNullException(nameof(viewLocationExpander));
return services.Configure<RazorViewEngineOptions>(options =>
options.ViewLocationExpanders.Add(viewLocationExpander);
);
Unit tests
[Fact]
public void ExtensionMethodAddsNewViewLocationExpander()
// Arrange
var services = new ServiceCollection();
services.AddMvc();
// These two are required to active the RazorViewEngineOptions.
services.AddSingleton<IHostingEnvironment, HostingEnvironment>();
services.AddSingleton<ILoggerFactory, LoggerFactory>();
// Act
var serviceProvider = services.BuildServiceProvider();
var oldOptions = serviceProvider.GetRequiredService<IOptions<RazorViewEngineOptions>>().Value;
services.AddViewLocationExpander(new ViewLocationExpander());
serviceProvider = services.BuildServiceProvider();
var newOptions = serviceProvider.GetRequiredService<IOptions<RazorViewEngineOptions>>().Value;
// Assert
Assert.True(newOptions.ViewLocationExpanders.Count > oldOptions.ViewLocationExpanders.Count);
Questions
- Am I going beyond the scope of what unit testing should include? I'm afraid that my code is actually testing the basic functions of generic collections and/or aspects of ASP.NET Core.
- If my concern above is true, that should I write unit tests to this at all? How should it work?
c# unit-testing asp.net-core
$endgroup$
add a comment |
$begingroup$
Introduction
I'm writing unit tests for an extension method I wrote. Its only purpose it is to wrap startup logic which extends ViewLocationExpanders
list by an instance implementating IViewLocationExpander
. ViewLocationExpanders
is a property of RazorViewEngineOptions
, which can be configured in application startup in ConfigureServices()
method. I'm using XUnit 2.4.1.
Usage
Instead of:
services.Configure<RazorViewEngineOptions>(options =>
options.ViewLocationExpanders.Add(new ViewLocationExpander());
);
I can use:
services.AddViewLocationExpander(new ViewLocationExpander());
ViewLocationExpander
public class ViewLocationExpander : IViewLocationExpander
public IEnumerable<string> ExpandViewLocations(
ViewLocationExpanderContext context,
IEnumerable<string> viewLocations)
if (context == null)
throw new ArgumentNullException(nameof(context));
if (viewLocations == null)
throw new ArgumentNullException(nameof(viewLocations));
/*
* Note:
* 0 = action name
* 1 = controller name
* 2 = area name
*/
var newViewLocations = new string[]
// Example: '/Views/Home/_Partials/FooBar.cshtml'
"/Views/1/_Partials/0.cshtml",
;
// Add new locations *AFTER* MVC default locations.
return viewLocations.Union(newViewLocations);
public void PopulateValues(ViewLocationExpanderContext context)
context.Values["customviewlocation"] = nameof(ViewLocationExpander);
Extension method
public static IServiceCollection AddViewLocationExpander(
this IServiceCollection services,
IViewLocationExpander viewLocationExpander)
if (services == null)
throw new ArgumentNullException(nameof(services));
if (viewLocationExpander == null)
throw new ArgumentNullException(nameof(viewLocationExpander));
return services.Configure<RazorViewEngineOptions>(options =>
options.ViewLocationExpanders.Add(viewLocationExpander);
);
Unit tests
[Fact]
public void ExtensionMethodAddsNewViewLocationExpander()
// Arrange
var services = new ServiceCollection();
services.AddMvc();
// These two are required to active the RazorViewEngineOptions.
services.AddSingleton<IHostingEnvironment, HostingEnvironment>();
services.AddSingleton<ILoggerFactory, LoggerFactory>();
// Act
var serviceProvider = services.BuildServiceProvider();
var oldOptions = serviceProvider.GetRequiredService<IOptions<RazorViewEngineOptions>>().Value;
services.AddViewLocationExpander(new ViewLocationExpander());
serviceProvider = services.BuildServiceProvider();
var newOptions = serviceProvider.GetRequiredService<IOptions<RazorViewEngineOptions>>().Value;
// Assert
Assert.True(newOptions.ViewLocationExpanders.Count > oldOptions.ViewLocationExpanders.Count);
Questions
- Am I going beyond the scope of what unit testing should include? I'm afraid that my code is actually testing the basic functions of generic collections and/or aspects of ASP.NET Core.
- If my concern above is true, that should I write unit tests to this at all? How should it work?
c# unit-testing asp.net-core
$endgroup$
add a comment |
$begingroup$
Introduction
I'm writing unit tests for an extension method I wrote. Its only purpose it is to wrap startup logic which extends ViewLocationExpanders
list by an instance implementating IViewLocationExpander
. ViewLocationExpanders
is a property of RazorViewEngineOptions
, which can be configured in application startup in ConfigureServices()
method. I'm using XUnit 2.4.1.
Usage
Instead of:
services.Configure<RazorViewEngineOptions>(options =>
options.ViewLocationExpanders.Add(new ViewLocationExpander());
);
I can use:
services.AddViewLocationExpander(new ViewLocationExpander());
ViewLocationExpander
public class ViewLocationExpander : IViewLocationExpander
public IEnumerable<string> ExpandViewLocations(
ViewLocationExpanderContext context,
IEnumerable<string> viewLocations)
if (context == null)
throw new ArgumentNullException(nameof(context));
if (viewLocations == null)
throw new ArgumentNullException(nameof(viewLocations));
/*
* Note:
* 0 = action name
* 1 = controller name
* 2 = area name
*/
var newViewLocations = new string[]
// Example: '/Views/Home/_Partials/FooBar.cshtml'
"/Views/1/_Partials/0.cshtml",
;
// Add new locations *AFTER* MVC default locations.
return viewLocations.Union(newViewLocations);
public void PopulateValues(ViewLocationExpanderContext context)
context.Values["customviewlocation"] = nameof(ViewLocationExpander);
Extension method
public static IServiceCollection AddViewLocationExpander(
this IServiceCollection services,
IViewLocationExpander viewLocationExpander)
if (services == null)
throw new ArgumentNullException(nameof(services));
if (viewLocationExpander == null)
throw new ArgumentNullException(nameof(viewLocationExpander));
return services.Configure<RazorViewEngineOptions>(options =>
options.ViewLocationExpanders.Add(viewLocationExpander);
);
Unit tests
[Fact]
public void ExtensionMethodAddsNewViewLocationExpander()
// Arrange
var services = new ServiceCollection();
services.AddMvc();
// These two are required to active the RazorViewEngineOptions.
services.AddSingleton<IHostingEnvironment, HostingEnvironment>();
services.AddSingleton<ILoggerFactory, LoggerFactory>();
// Act
var serviceProvider = services.BuildServiceProvider();
var oldOptions = serviceProvider.GetRequiredService<IOptions<RazorViewEngineOptions>>().Value;
services.AddViewLocationExpander(new ViewLocationExpander());
serviceProvider = services.BuildServiceProvider();
var newOptions = serviceProvider.GetRequiredService<IOptions<RazorViewEngineOptions>>().Value;
// Assert
Assert.True(newOptions.ViewLocationExpanders.Count > oldOptions.ViewLocationExpanders.Count);
Questions
- Am I going beyond the scope of what unit testing should include? I'm afraid that my code is actually testing the basic functions of generic collections and/or aspects of ASP.NET Core.
- If my concern above is true, that should I write unit tests to this at all? How should it work?
c# unit-testing asp.net-core
$endgroup$
Introduction
I'm writing unit tests for an extension method I wrote. Its only purpose it is to wrap startup logic which extends ViewLocationExpanders
list by an instance implementating IViewLocationExpander
. ViewLocationExpanders
is a property of RazorViewEngineOptions
, which can be configured in application startup in ConfigureServices()
method. I'm using XUnit 2.4.1.
Usage
Instead of:
services.Configure<RazorViewEngineOptions>(options =>
options.ViewLocationExpanders.Add(new ViewLocationExpander());
);
I can use:
services.AddViewLocationExpander(new ViewLocationExpander());
ViewLocationExpander
public class ViewLocationExpander : IViewLocationExpander
public IEnumerable<string> ExpandViewLocations(
ViewLocationExpanderContext context,
IEnumerable<string> viewLocations)
if (context == null)
throw new ArgumentNullException(nameof(context));
if (viewLocations == null)
throw new ArgumentNullException(nameof(viewLocations));
/*
* Note:
* 0 = action name
* 1 = controller name
* 2 = area name
*/
var newViewLocations = new string[]
// Example: '/Views/Home/_Partials/FooBar.cshtml'
"/Views/1/_Partials/0.cshtml",
;
// Add new locations *AFTER* MVC default locations.
return viewLocations.Union(newViewLocations);
public void PopulateValues(ViewLocationExpanderContext context)
context.Values["customviewlocation"] = nameof(ViewLocationExpander);
Extension method
public static IServiceCollection AddViewLocationExpander(
this IServiceCollection services,
IViewLocationExpander viewLocationExpander)
if (services == null)
throw new ArgumentNullException(nameof(services));
if (viewLocationExpander == null)
throw new ArgumentNullException(nameof(viewLocationExpander));
return services.Configure<RazorViewEngineOptions>(options =>
options.ViewLocationExpanders.Add(viewLocationExpander);
);
Unit tests
[Fact]
public void ExtensionMethodAddsNewViewLocationExpander()
// Arrange
var services = new ServiceCollection();
services.AddMvc();
// These two are required to active the RazorViewEngineOptions.
services.AddSingleton<IHostingEnvironment, HostingEnvironment>();
services.AddSingleton<ILoggerFactory, LoggerFactory>();
// Act
var serviceProvider = services.BuildServiceProvider();
var oldOptions = serviceProvider.GetRequiredService<IOptions<RazorViewEngineOptions>>().Value;
services.AddViewLocationExpander(new ViewLocationExpander());
serviceProvider = services.BuildServiceProvider();
var newOptions = serviceProvider.GetRequiredService<IOptions<RazorViewEngineOptions>>().Value;
// Assert
Assert.True(newOptions.ViewLocationExpanders.Count > oldOptions.ViewLocationExpanders.Count);
Questions
- Am I going beyond the scope of what unit testing should include? I'm afraid that my code is actually testing the basic functions of generic collections and/or aspects of ASP.NET Core.
- If my concern above is true, that should I write unit tests to this at all? How should it work?
c# unit-testing asp.net-core
c# unit-testing asp.net-core
asked 5 hours ago
PrologProlog
468
468
add a comment |
add a comment |
1 Answer
1
active
oldest
votes
$begingroup$
I find your test is excelent (and I'll borrow it from you). I would, however, make it a litte bit more exact and not only test the counts of generated locations but also whether they have the expected values.
You are not testing basic functions of collections or ASP.NET-Core aspects because it doesn't matter how it's implemented. What you are testing is whether your application has all the view locations it needs to work correctly.
This is a very important (integration) test and you should not remove it but improve it by asserting the actual locations too. If this breaks then your app wont't work anymore so it's a real lifesaver.
$endgroup$
$begingroup$
Thank you for answer. Maybe I should write further integration test checking if appropriate views are found with the newViewLocationExpanderadded
? But that would probably be outside the scope of unit testing and secondly inside that unit test method there is not much more to test (or at least I see it that way in debugger). And please, go ahead and borrow anything you want from my post. I'm happy it's useful.
$endgroup$
– Prolog
1 hour ago
add a comment |
Your Answer
StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");
StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "196"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);
else
createEditor();
);
function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);
);
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217748%2funit-testing-extension-method-adding-view-location-expander%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
$begingroup$
I find your test is excelent (and I'll borrow it from you). I would, however, make it a litte bit more exact and not only test the counts of generated locations but also whether they have the expected values.
You are not testing basic functions of collections or ASP.NET-Core aspects because it doesn't matter how it's implemented. What you are testing is whether your application has all the view locations it needs to work correctly.
This is a very important (integration) test and you should not remove it but improve it by asserting the actual locations too. If this breaks then your app wont't work anymore so it's a real lifesaver.
$endgroup$
$begingroup$
Thank you for answer. Maybe I should write further integration test checking if appropriate views are found with the newViewLocationExpanderadded
? But that would probably be outside the scope of unit testing and secondly inside that unit test method there is not much more to test (or at least I see it that way in debugger). And please, go ahead and borrow anything you want from my post. I'm happy it's useful.
$endgroup$
– Prolog
1 hour ago
add a comment |
$begingroup$
I find your test is excelent (and I'll borrow it from you). I would, however, make it a litte bit more exact and not only test the counts of generated locations but also whether they have the expected values.
You are not testing basic functions of collections or ASP.NET-Core aspects because it doesn't matter how it's implemented. What you are testing is whether your application has all the view locations it needs to work correctly.
This is a very important (integration) test and you should not remove it but improve it by asserting the actual locations too. If this breaks then your app wont't work anymore so it's a real lifesaver.
$endgroup$
$begingroup$
Thank you for answer. Maybe I should write further integration test checking if appropriate views are found with the newViewLocationExpanderadded
? But that would probably be outside the scope of unit testing and secondly inside that unit test method there is not much more to test (or at least I see it that way in debugger). And please, go ahead and borrow anything you want from my post. I'm happy it's useful.
$endgroup$
– Prolog
1 hour ago
add a comment |
$begingroup$
I find your test is excelent (and I'll borrow it from you). I would, however, make it a litte bit more exact and not only test the counts of generated locations but also whether they have the expected values.
You are not testing basic functions of collections or ASP.NET-Core aspects because it doesn't matter how it's implemented. What you are testing is whether your application has all the view locations it needs to work correctly.
This is a very important (integration) test and you should not remove it but improve it by asserting the actual locations too. If this breaks then your app wont't work anymore so it's a real lifesaver.
$endgroup$
I find your test is excelent (and I'll borrow it from you). I would, however, make it a litte bit more exact and not only test the counts of generated locations but also whether they have the expected values.
You are not testing basic functions of collections or ASP.NET-Core aspects because it doesn't matter how it's implemented. What you are testing is whether your application has all the view locations it needs to work correctly.
This is a very important (integration) test and you should not remove it but improve it by asserting the actual locations too. If this breaks then your app wont't work anymore so it's a real lifesaver.
answered 3 hours ago
t3chb0tt3chb0t
35.3k754127
35.3k754127
$begingroup$
Thank you for answer. Maybe I should write further integration test checking if appropriate views are found with the newViewLocationExpanderadded
? But that would probably be outside the scope of unit testing and secondly inside that unit test method there is not much more to test (or at least I see it that way in debugger). And please, go ahead and borrow anything you want from my post. I'm happy it's useful.
$endgroup$
– Prolog
1 hour ago
add a comment |
$begingroup$
Thank you for answer. Maybe I should write further integration test checking if appropriate views are found with the newViewLocationExpanderadded
? But that would probably be outside the scope of unit testing and secondly inside that unit test method there is not much more to test (or at least I see it that way in debugger). And please, go ahead and borrow anything you want from my post. I'm happy it's useful.
$endgroup$
– Prolog
1 hour ago
$begingroup$
Thank you for answer. Maybe I should write further integration test checking if appropriate views are found with the new
ViewLocationExpanderadded
? But that would probably be outside the scope of unit testing and secondly inside that unit test method there is not much more to test (or at least I see it that way in debugger). And please, go ahead and borrow anything you want from my post. I'm happy it's useful.$endgroup$
– Prolog
1 hour ago
$begingroup$
Thank you for answer. Maybe I should write further integration test checking if appropriate views are found with the new
ViewLocationExpanderadded
? But that would probably be outside the scope of unit testing and secondly inside that unit test method there is not much more to test (or at least I see it that way in debugger). And please, go ahead and borrow anything you want from my post. I'm happy it's useful.$endgroup$
– Prolog
1 hour ago
add a comment |
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217748%2funit-testing-extension-method-adding-view-location-expander%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown